Dear Peter Tyser,
In message <[EMAIL PROTECTED]> you wrote:
>
> > You indent the lines by a single space, but they should be indented by
> > a TAB.
>
> Many boards I look at don't use TABS. In particular Freescale reference
> platforms. Many boards even have different amounts of spaces:) I don't
The fact that earlier submissions pased less strict revierws is nop
excuse or reason to accept code that violated the Coding Style
requirements.
On contrary - if you are aware of such Coding Style problems, then
patches to fix these are highly appreciated.
> That define is no longer than the standard CONFIG_EXTRA_ENV_SETTINGS
> define that its used in, or any number of other standard defines. And
> they aren't used anywhere other than this 40 line section of code in 1
> file. I thought the increase in clarity of long defines made up for
> their ugliness. I'll go ahead and split the lines on the ';' as you
> suggested.
PLease re-read the Coding Style requirements, especially "Chapter 4:
Naming".
> You have the final say, so if any of the above are sticking points to
> getting the code accepted let me know and I'll change them as requested.
I wouldn't have mentioned it here if I didn't care about it.
Thanks.
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
A little suffering is good for the soul.
-- Kirk, "The Corbomite Maneuver", stardate 1514.0
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
