Dear Peter Tyser, In message <[EMAIL PROTECTED]> you wrote: > > > I'm not sure if we need such a detailed level of access to these > > chips. We already have a couple of similar I/O expanders in some > > boards, for example implemente in some PICs. See for example the "pic > > read" / "pic write" conde in board/lwmon/lwmon.c etc. > > > > I think we should generalize this - and more than read / write isn't > > really needed, or is it? > > What do you mean by "we should generalize this"?
Cre4ate a common version of the code that can be used in all of these boards. > I view the read/write/invert commands as necessary to easily > configure/read/write the GPIO pins, and the info command is nice, but > not necessary. I never needed an invert command yet, but it probably doesn't hurt either, and so does info. > The info command is nice to get an idea of what's going on at a high > level - eg is the input on pin 2 being inverted? What pins are > currently being driven low? etc. I've found the iopinfo command useful > for the 82xx boards and tried to replicate similar functionality in this > driver. I like the info command but understand if others want it > removed. Don't remove it, but maybe make it a selectable option so those who like it can include it while others that are tryting to minimize the memory footprint don't suffer from it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Bradley's Bromide: If computers get too powerful, we can organize them into a committee - that will do them in. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
