On Monday 02 February 2009, Becky Bruce wrote: > include/flash.h was commented to say that the address in > flash_info->start was a physical address. However, from u-boot's > point of view, and looking at most flash code, it makes more > sense for this to be a virtual address. So I corrected the > comment to indicate that this was a virtual address. > > The only flash driver that was actually treating the address > as physical was the mtd/cfi_flash driver. However, this code > was using it inconsistently as it actually directly dereferenced > the "start" element, while it used map_physmem to get a > virtual address in other places. I changed this driver so > that the code which initializes the info->start field calls > map_physmem to get a virtual address, eliminating the need for > further map_physmem calls. The code is now consistent. > > The *only* place a physical address should be used is when defining the > flash banks list that is used to initialize the flash_info struct, > usually found in the board config file.
Applied to cfi-flash/master. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
