On Tuesday 03 February 2009, Kumar Gala wrote: > On Feb 3, 2009, at 2:53 AM, Pieter wrote: > >> static inline void flash_unmap(flash_info_t *info, flash_sect_t sect, > >> unsigned int offset, void *addr) > >> { > >> - unsigned int byte_offset = offset * info->portwidth; > >> - > >> - unmap_physmem(addr, flash_sector_size(info, sect) - byte_offset); > >> } > > > > <snip> > > > > Since "flash_unmap(flash_info_t *info, flash_sect_t sect,unsigned > > int offset, void *addr)" function is empty after applying the patch, > > should all function calls in the /drivers/mtd/cfi_flash.c file not > > also be removed? > > > > cheers pieter > > I think its best to leave them alone for now. If in the future we > really think flash_unmap isn't going to get called we can remove > them. Stefan?
Fine with me. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot