On Thu, Feb 7, 2013 at 6:17 PM, Wolfgang Denk <w...@denx.de> wrote:
> Dear Sonic Zhang,
>
> In message <1360223258-6945-9-git-send-email-sonic....@gmail.com> you wrote:
>> From: Sonic Zhang <sonic.zh...@analog.com>
>>
>> Add rsi/sdh support for bf60x.
>
> Checkpatch errors.  Please fix.

OK

>
>> @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct 
>> mmc_data *data)
> ...
>> -     int ret = 0;
> ...
>> -     return ret;
>> +     return 0;
>
> If this function can always only return 0, then please make it void.
>
> Please fix globally.
>

Yes

Thanks,

Sonic
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to