On Thu, Feb 7, 2013 at 6:17 PM, Wolfgang Denk <w...@denx.de> wrote:
> Dear Sonic Zhang,
>
> In message <1360223258-6945-9-git-send-email-sonic....@gmail.com> you wrote:
>> From: Sonic Zhang <sonic.zh...@analog.com>
>>
>> Add rsi/sdh support for bf60x.
>
> Checkpatch errors. Please fix.
>
>> @@ -113,16 +131,19 @@ static int sdh_setup_data(struct mmc *mmc, struct
>> mmc_data *data)
> ...
>> - int ret = 0;
> ...
>> - return ret;
>> + return 0;
>
> If this function can always only return 0, then please make it void.
>
> Please fix globally.
I am sorry, this function can't be changed to void, because it may
return error. See bellow code.
static int sdh_setup_data(struct mmc *mmc, struct mmc_data *data)
{
u16 data_ctl = 0;
u16 dma_cfg = 0;
unsigned long data_size = data->blocksize * data->blocks;
/* Don't support write yet. */
if (data->flags & MMC_DATA_WRITE)
return UNUSABLE_ERR;
......
Regards,
Sonic
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
