Hi Benoît, On Wed, 3 Apr 2013 08:30:12 +0200 (CEST), Benoît Thébaudeau <benoit.thebaud...@advansee.com> wrote:
> Hi Albert, > > Here is the v10 bundle for those who want to test: > http://dl.free.fr/vdXBGExyq Thanks, will build-test it ASAP. People with ARM (expecially tx25 and mx31pdk) and non-ARM boards please run-test it too. > The resulting HEAD is identical to yours, except for > board/freescale/mx31ads/u-boot.lds in which you had removed the following > unrelated line for 30/30: > __bss_end = .; > > Regarding this line, it is also present in a few other .lds, as well as the > following ones: > KEEP(*(.__bss_start)); > KEEP(*(__bss_end)); > > However, the end section is named .__bss_end in arch/arm/lib/bss.c, so there > is > perhaps something wrong here, unless you did that on purpose because of the > __bss_end test at the end of the linker script. I had noticed that, but I let > you handle it. If something needs to be changed here, please do it after my > series if possible in order to avoid a v11 because of newer rebase conflicts. > ;) Normally, defining __bss_end symbols in the ARM lds files has become unnecessary as arch/arm/lib/bss.c now defines then (and in so doing avoids generating ugly R_ARM_ABS32 relocation records) so yes, the line removal was intentional, but indeed unrelated to your series. As for the missing period in the .__bss_end input section specification, thanks for bringing this to my attention. I'll give it a look at once as this could lead to tricky bugs popping up... > I have also noticed that patman is broken in u-boot-arm/master. I don't know > if > this has already been fixed somewhere, but it fails with an internal error > while > running checkpatch, as if an incompatible API change had been made to > checkpatch > recently, and not propagated to patman. Cc:ing Simon Glass on patman. Note: u-boot-arm/master is pretty close to u-boot/master at the moment. > Best regards, > Benoît Amicalement, -- Albert. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot