Hi Stefano, Le Fri, 19 Apr 2013 10:15:49 +0200, Stefano Babic <sba...@denx.de> a écrit :
> On 18/04/2013 19:37, Wolfgang Denk wrote: > > Dear Pierre Aubert, > > > > In message <1366296086-22394-1-git-send-email-p.aub...@staubli.com> you > > wrote: > >> The SabreSD platform is available with i.MX6Q or i.MX6DL. This patch adds > >> the > >> support of the i.MX6DL. The config file and the board directory are renamed > >> to remove the reference to the MX6Q. > > > > Formal issues: > > > > - entry to MAINTAINERS file missing > > - there are 2 checkpatch warnings ("please, no spaces at the start of > > a line") that need to be fixed. > > > >> int checkboard(void) > >> { > >> - puts("Board: MX6Q-SabreSD\n"); > >> - > >> +#ifdef CONFIG_MX6Q > >> + puts("Board: MX6Q-SabreSD\n"); > >> +#else > >> + puts("Board: MX6DL-SabreSD\n"); > >> +#endif > > > > Can we please avoid such #ifdef's? Here, we could for example refer > > to the board name (CONFIG_SYS_BOARD if you like the name, or some > > custom defined CONFIG_BOARD_NAME like other boards do). > > And who does set CONFIG_MX6Q ? You drop it, but I do not see who sets it. > that's done in boards.cfg : +++ b/boards.cfg +mx6qsabreauto arm armv7 mx6qsabreauto freescale mx6 mx6qsabreauto:IMX_CONFIG=board/freescale/mx6qsabreauto/imximage.cfg,MX6Q Eric _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot