Dear Heiko Schocher, In message <49d05e5f.6060...@denx.de> you wrote: > ... > Independent from your patch, I think we need here a common > rule. Either we name in future this define "CONFIG_I2C_XXX" > or "CONFIG_XXX_I2C. I vote for using "CONFIG_I2C_XXX"
Me too. ... > > +#ifdef CONFIG_HARD_I2C > > Why not "#if defined(CONFIG_I2C_ATMEL)" as in the Makefile? Excellent question. > > +#if 0 /* EEPROM code already sets this correctly */ > > + chip |= (addr >> 8) & 0xff; > > +#endif > > > > please remove dead code. Agreed. > > +#if 0 /* EEPROM code already sets this correctly */ > > + chip |= (addr >> 8) & 0xff; > > +#endif > > here too, please remove dead code. Ditto. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Anyone can count the seeds in an apple. No one can count the apples in a seed. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
