Hi Marek, On Wed, 15 May 2013 05:36:14 +0200, Marek Vasut <ma...@denx.de> wrote:
> Dear Axel Lin, > > > cpu_init_crit() can be skipped, but the code is still enabled requiring a > > platform to supply lowlevel_init(). > > > > Signed-off-by: Axel Lin <axel....@ingics.com> > > Nice CC list, it'd be the best if you CCed the ARM maintainer too though ;-) Thanks Marek. :) > > --- > > arch/arm/cpu/arm720t/start.S | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S > > index 9facc7e..9f0e3f9 100644 > > --- a/arch/arm/cpu/arm720t/start.S > > +++ b/arch/arm/cpu/arm720t/start.S > > @@ -244,6 +244,7 @@ c_runtime_cpu_setup: > > ************************************************************************* > > */ > > > > +#ifndef CONFIG_SKIP_LOWLEVEL_INIT > > cpu_init_crit: > > > > #if !defined(CONFIG_TEGRA) > > @@ -258,6 +259,7 @@ cpu_init_crit: > > #endif > > > > mov pc, lr > > +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */ > > > > > > #ifndef CONFIG_SPL_BUILD I am tempted to ask: what actual issue does this guarding aim at solving? Just in case, beware that AFAIR Wolfgang does not consider 'because debugging' a valid answer. > Best regards, > Marek Vasut Amicalement, -- Albert. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot