On 05/14/2013 09:04 PM, Axel Lin wrote:
> cpu_init_crit() can be skipped, but the code is still enabled requiring a
> platform to supply lowlevel_init().

> diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S

> +#ifndef CONFIG_SKIP_LOWLEVEL_INIT
>  cpu_init_crit:
>  
>  #if !defined(CONFIG_TEGRA)
> @@ -258,6 +259,7 @@ cpu_init_crit:
>  #endif
>  
>       mov     pc, lr
> +#endif /* CONFIG_SKIP_LOWLEVEL_INIT */

If you're going to make changes here, you should probably ensure that
Tegra is setting CONFIG_SKIP_LOWLEVEL_INIT, and then remove the
Tegra-specific ifdef from the body of that function. That's assuming
that setting CONFIG_SKIP_LOWLEVEL_INIT doesn't have any other side-effects.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to