On Mon, Feb 17, 2014 at 11:56:37AM -0600, Dennis Gilmore wrote:

[snip]
> -             "nand read ${fdtaddr} u-boot-spl-os; " \
> +             "nand read ${fdt_addr} u-boot-spl-os; " \
>               "nand read ${loadaddr} kernel; " \
> -             "bootz ${loadaddr} - ${fdtaddr}\0"
> +             "bootz ${loadaddr} - ${fdt_addr}\0"

In all of these conversions you should switch loadaddr to kernel_addr_r
too.

[snip]
> -     "fdtfile=undefined\0" \

That's a problem.  Need this for 'findfdt' to work.

> -     "rootpath=/export/rootfs\0" \
> -     "nfsopts=nolock\0" \
> -     "static_ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}:${hostname}" \
> -             "::off\0" \
[snip]
> -     "spiroot=/dev/mtdblock4 rw\0" \
> -     "spirootfstype=jffs2\0" \
> -     "spisrcaddr=0xe0000\0" \
> -     "spiimgsize=0x362000\0" \
> -     "spibusno=0\0" \
> -     "spiargs=setenv bootargs console=${console} " \
> -             "${optargs} " \
> -             "root=${spiroot} " \
> -             "rootfstype=${spirootfstype}\0" \
> -     "netargs=setenv bootargs console=${console} " \
> -             "${optargs} " \
> -             "root=/dev/nfs " \
> -             "nfsroot=${serverip}:${rootpath},${nfsopts} rw " \
> -             "ip=dhcp\0" \
[snip]
> -     "spiboot=echo Booting from spi ...; " \
> -             "run spiargs; " \
> -             "sf probe ${spibusno}:0; " \
> -             "sf read ${loadaddr} ${spisrcaddr} ${spiimgsize}; " \
> -             "bootz ${loadaddr}\0" \
> -     "netboot=echo Booting from network ...; " \
> -             "setenv autoload no; " \
> -             "dhcp; " \
> -             "tftp ${loadaddr} ${bootfile}; " \
> -             "tftp ${fdtaddr} ${fdtfile}; " \
> -             "run netargs; " \
> -             "bootz ${loadaddr} - ${fdtaddr}\0" \
> -     "ramboot=echo Booting from ramdisk ...; " \
> -             "run ramargs; " \
> -             "bootz ${loadaddr} ${rdaddr} ${fdtaddr}\0" \

And this is functionality I don't see in the generic distro config that
we still need.

[snip]
>  /*
> - * Common filesystems support.  When we have removable storage we
> - * enabled a number of useful commands and support.
> + * Include the generic config options and boot environment when not
> + * building our SPL
>   */
> -#if defined(CONFIG_MMC) || defined(CONFIG_USB_STORAGE)
> -#define CONFIG_DOS_PARTITION
> -#define CONFIG_CMD_FAT
> -#define CONFIG_FAT_WRITE
> -#define CONFIG_CMD_EXT2
> -#define CONFIG_CMD_EXT4
> -#define CONFIG_CMD_FS_GENERIC
> +#ifndef CONFIG_SPL_BUILD
> +#include <config_distro_defaults.h>
> +#include <config_distro_bootcmd.h>
>  #endif

This is fine, for now, but I'll have to shuffle things around later as
some of the good feedback I'd gotten off-list about ti_armv7_common.h is
that it's not as useful for non-Linux targets, so I need to adjust the
contents a bit more.

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to