On Thu, Oct 23, 2014 at 04:15:24PM +0200, Matthias Fuchs wrote: > Hi Valentin, > > On 10/14/2014 04:21 PM, Valentin Longchamp wrote: > > Hi Matthias, > > > > On 10/14/2014 02:32 PM, Matthias Fuchs wrote: > >> Hi Valentin, > >> > >> my patch fixed environment from i2c eeprom. I am not sure on which board > >> I ran into that trouble. Probably PMC440. So reverting my former patch > >> will break environment in i2c eeprom again on many boards. > > > > Good that you have answered to patch. I run into that trouble on our Keymile > > boards that have the environment in the EEPROM. On our boards, the > > environment > > eeprom works with or without your patch. However, with your patch, I cannot > > directly access ANY eeprom which is not on the CONFIG_I2C_ENV_EEPROM_BUS > > bus. > > > >> > >> But perhaps there's a better way to fix that. > > > > I think that the proposal that Holger made to actually define > > CONFIG_I2C_ENV_EEPROM_BUS for your boards is what I would try first. > I reverted my former patch and switchedd towards > CONFIG_I2C_ENV_EEPROM_BUS. This works fine for me. > > So I ack your patch to revert mine :-)
Can you reply with an Acked-by for patchwork to pick up? And then a patch to update your board to work right as well please. Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
