On 02/17/2015 03:29 PM, Simon Glass wrote:
From: Doug Anderson <diand...@chromium.org>

This header includes useful scripts which can be used with any board that
can boot Chrome OS.

In particular, 'run nvboot' will boot a board without verified boot enabled.

I think this needs a bit of minification for an upstream U-Boot. In particular, many of the environment variables overlap semantically or by name with those from include/config_distro_*.h, and I'd like to see any U-Boot for the Tegra Chromebooks (at least) support booting both ChromeOS kernels and arbitrary distros using the environment from config_distro_bootcmd.h.

diff --git a/include/configs/chromeos.h b/include/configs/chromeos.h

+/* Stringify a token */
+#ifndef STRINGIFY
+#define _STRINGIFY(x)  #x
+#define STRINGIFY(x)   _STRINGIFY(x)
+#endif

Shouldn't that be in some common header so it isn't ever duplicated?

+#define CONFIG_CROS_FULL

There are a ton of macros in here without much in the way of explanation. Shouldn't everything be documented in the README?
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to