Nishanth Menon wrote:
> Jean-Christophe PLAGNIOL-VILLARD said the following on 07/12/2009 08:13 AM:
>>>> _sread*/\
>>>> + MUX_VAL(CP(D2D_MBUSFLAG),     (IEN  | PTD | DIS | M0)) /*d2d_mbusflag*/\
>>>> + MUX_VAL(CP(D2D_SBUSFLAG),     (IEN  | PTD | DIS | M0)) /*d2d_sbusflag*/\
>>>> + MUX_VAL(CP(SDRC_CKE0),                (IDIS | PTU | EN  | M0)) 
>>>> /*sdrc_cke0*/\
>>>> + MUX_VAL(CP(SDRC_CKE1),                (IDIS | PTU | EN  | M0)) 
>>>> /*sdrc_cke1*/
>>>>       
>>> one more reason why the mux needs a big change in mux handling :( I
>>> think we will end up with 1/2 a dozen crazy and code repetition for
>>> each board... Arrggghhh...
>>>     
>> NM: yes, it's really not easy to follow here
>> do you plan to do it soon?
>>   
> Been a little tied up recent days with "work load" hoping things to ease
> down.. will try to send out a mux cleanup rev next weekend..

Btw, I like the way we do pin mux in U-Boot at the moment (*). Or 
better: I can't imagine a way how to do it even better without 
introducing other disadvantages. But I will enjoy to have a look to 
your changes ;) Maybe you can give us already an idea of how you like 
to change it?

(*) What I like:

Having everything in one file for each board. With this, you can get a 
complete overview of board's pin mux with looking only in one file. 
And you can see immediately for each pin what is configured and how.

Best regards

Dirk
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to