2015-07-24 6:21 GMT+09:00 Tom Rini <tr...@konsulko.com>: > On Thu, Jul 23, 2015 at 05:19:39PM +0300, Nikita Kiryanov wrote: > >> Add option to set shell prompt string from menuconfig and use it >> when migrating CONFIG_SYS_PROMPT to cm-fx6 defconfig. >> >> Cc: Tom Rini <tr...@konsulko.com> >> Cc: Masahiro Yamada <yamad...@jp.panasonic.com> >> Cc: Stefano Babic <sba...@denx.de> >> Cc: Igor Grinberg <grinb...@compulab.co.il> >> Signed-off-by: Nikita Kiryanov <nik...@compulab.co.il> > > Conceptually, I like.
This patch breaks many boards. $ make zmx25_defconfig && make CROSS_COMPILE=arm-linux-gnueabi- ... CC arch/arm/cpu/arm926ejs/cpu.o In file included from include/config.h:5:0, from include/common.h:18, from arch/arm/cpu/arm926ejs/cpu.c:16: include/configs/zmx25.h:141:0: warning: "CONFIG_SYS_PROMPT" redefined [enabled by default] In file included from ././include/linux/kconfig.h:4:0, from <command-line>:0: include/generated/autoconf.h:48:0: note: this is the location of the previous definition CC arch/arm/cpu/arm926ejs/cache.o In file included from include/config.h:5:0, from include/common.h:18, from arch/arm/cpu/arm926ejs/cache.c:8: include/configs/zmx25.h:141:0: warning: "CONFIG_SYS_PROMPT" redefined [enabled by default] In file included from ././include/linux/kconfig.h:4:0, from <command-line>:0: include/generated/autoconf.h:48:0: note: this is the location of the previous definition CC arch/arm/cpu/arm926ejs/mx25/generic.o In file included from include/config.h:5:0, from include/common.h:18, from arch/arm/cpu/arm926ejs/mx25/generic.c:12: include/configs/zmx25.h:141:0: warning: "CONFIG_SYS_PROMPT" redefined [enabled by default] In file included from ././include/linux/kconfig.h:4:0, from <command-line>:0: This move should be done globally like what Joe does. >> --- >> common/Kconfig | 7 +++++++ >> configs/cm_fx6_defconfig | 1 + >> include/configs/cm_fx6.h | 1 - >> 3 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/common/Kconfig b/common/Kconfig >> index 40cd69e..6b24fd9 100644 >> --- a/common/Kconfig >> +++ b/common/Kconfig >> @@ -17,6 +17,13 @@ config SYS_HUSH_PARSER >> help >> Backward compatibility. >> >> +config SYS_PROMPT >> + string "Shell prompt" >> + default "# " > > How about "U-Boot> " which while not what I had been forcing everyone in > TI-land to use, is the most common. No. We had already decided the default prompt is "=> ". See include/config_fallbacks.h and below: commit 0defddc851edfc34bcf3c3379fe74b11dc01a493 Author: Rob Herring <rob.herr...@calxeda.com> Date: Mon Sep 30 17:11:48 2013 -0500 config: Add a default CONFIG_SYS_PROMPT The definitions for CONFIG_SYS_PROMPT are varied with little reason other than to display the board name. Over half the definitions are "==> ", so make this the default. The rest of the boards remain unchanged to avoid breaking any external scripts expecting a certain prompt. Signed-off-by: Rob Herring <rob.herr...@calxeda.com> Reviewed-by: Fabio Estevam <fabio.este...@freescale.com> -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot