Le mardi 01 septembre 2015 à 14:54 +0100, Ian Campbell a écrit : > On Tue, 2015-09-01 at 13:29 +0200, Maxime Ripard wrote: > > On Tue, Sep 01, 2015 at 11:46:05AM +0100, Ian Campbell wrote: > > > On Tue, 2015-09-01 at 11:00 +0200, Paul Kocialkowski wrote: > > > > Le mardi 01 septembre 2015 à 08:08 +0100, Ian Campbell a écrit : > > > > > On Mon, 2015-08-31 at 16:46 +0200, Maxime Ripard wrote: > > > > > > When using the fastboot boot command, the image sent to U-Boot > > > > > > will > > > > > > be an > > > > > > Android boot image. If the support is missing, that won't > > > > > > obviously > > > > > > work, > > > > > > so we need it in our configuration. > > > > > > > > > > Dumb question: Is it possible to boot anything _other_ than an > > > > > android > > > > > boot image via fastboot? > > > > > > > > > > If not then one of the two config options really ought to imply the > > > > > other. > > > > > > > > Well, those options have not been moved to Kconfig yet, but when they > > > > do, there should indeed be such a dependency. > > > > > > > > Otherwise, I believe it still makes sense to have two separate > > > > options > > > > because one might want Android boot image support without fastboot. > > > > > > Then fastboot should depend on android boot image support but not vice > > > -versa. > > > > Indeed, but it's not yet a Kconfig option. > > I'm not sure that's a necessary prerequisite, in some common place do: > > #if defined(CONFIG_CMD_FASTBOOT) && !defined(CONFIG_ANDROID_BOOT_IMAGE) > #define CONFIG_ANDROID_BOOT_IMAGE > #endif
Well, I'm not sure adding Kconfig-style logic really is a good idea as it removes some incentive to do things right and move everything over to Kconfig (which is out of the scope of this patch set, I believe). In addition, I don't see what a relevant place to but this in would be. Putting that in sunxi-common.h is just adding two useless extra lines (having the define is sufficient). Overall, I don't think this is a good idea when we have Kconfig around the corner to do things right… -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/
signature.asc
Description: This is a digitally signed message part
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
