Hi Maxime,

On 21.10.2015 16:31, Maxime Ripard wrote:
On 18.10.2015 11:34, Maxime Ripard wrote:
On 01-10-15 11:41, Stefan Roese wrote:
The ICnova-A20-SWAC is a baseboard, equipped with the ICnova-A20 SoM from
In-Circuit:

http://wiki.in-circuit.de/index.php5?title=ICnova_A20_SODIMM
http://linux-sunxi.org/In-Circuit_ICnova_A20

This patch adds support for this board, including ethernet, LCD and USB
support.

Thanks, I've merged this and it will show up in u-boot-sunxi/next soon.

I've made 2 small changes, see comments inline.

Signed-off-by: Stefan Roese <s...@denx.de>
Cc: Marcus Heuer <marcus.he...@swac.de>
Cc: Hans de Goede <hdego...@redhat.com>
Cc: Ian Campbell <i...@hellion.org.uk>
---
  arch/arm/dts/Makefile                      |   1 +
  arch/arm/dts/sun7i-a20-icnova-a20-swac.dts | 177 +++++++++++++++++++++++++++++
  board/sunxi/MAINTAINERS                    |   5 +
  configs/icnova-a20-swac_defconfig          |  21 ++++
  4 files changed, 204 insertions(+)
  create mode 100644 arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
  create mode 100644 configs/icnova-a20-swac_defconfig

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 5f10243..1f2661c 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -134,6 +134,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
        sun7i-a20-cubietruck.dtb \
        sun7i-a20-hummingbird.dtb \
        sun7i-a20-i12-tvbox.dtb \
+       sun7i-a20-icnova-a20-swac.dtb \
        sun7i-a20-m3.dtb \
        sun7i-a20-m5.dtb \
        sun7i-a20-mk808c.dtb \
diff --git a/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts 
b/arch/arm/dts/sun7i-a20-icnova-a20-swac.dts
new file mode 100644

Please submit this file also to the upstream kernel.

Yes. The name of the DT especially doesn't really make sense. The
"SWAC" name isn't referenced anywhere, the module cannot be used
alone, and there's a single combination available (A20 SODIMM +
ADB4006)

At least one other combination is available. A custom board from SWAC
equipped with the SoM.

Ah, my bad then. I was under the impression that you were adding
support for the SoM + ADB4006. Sorry.

No problem.

What is the preferred method to support SoM's
with multiple baseboards? Something like:

sun7i-a20-icnova.dtsi
sun7i-a20-icnova-adb4006.dts
sun7i-a20-icnova-swac.dts

?

Yep, that would make much more sense. I have an ADB4006 here, so I can
do that one if you want, but we should totally split the common part
in a DTSI.

Okay. I'll try to find some time tomorrow to split this and send
you a first version for Linux this time. Since I don't have the
ADB4006 baseboard it would be great if you could step in here.

Thanks,
Stefan

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to