Hello Fabio,
Am 26.10.2015 um 11:22 schrieb Fabio Estevam:
Hi Heiko,
On Mon, Oct 26, 2015 at 3:11 AM, Heiko Schocher <h...@denx.de> wrote:
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 41763a1..eaae5fb 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -31,7 +31,7 @@
#include <common.h>
#include <malloc.h>
#include <memalign.h>
-#include <linux/compat.h>
+#include <linux/log2.h>
#include <linux/stat.h>
#include <linux/err.h>
#include "ubifs.h"
It would be nice to ge rid of linux/compat.h at all in ubi/ubifs
code ... but does this really compile for all boards?
I haven't seen a board failure because of this change on the several
arch's/boards I have built.
Did you compilied all arm boards?
Could you please provide a failure case?
I did not tried your patches, but:
fs/ubifs/super.c calls a lot of functions, which are "defined" in
include/linux/compat.h
for example:
kfree
kmem_cache_alloc
mutex_init
spin_lock_init
...
I think you should add here linux/log2.h, without deleting linux/compat.h
My understanding is that linux/compat.h is currently used only for
providing is_power_of_2() in this file.
I think there is more used from include/linux/compat.h
Now that we have log2.h (which provides is_power_of_2()), we can
simply use it instead.
Am I missing anything here?
I think the aristainetos or aristainetos2 board will fail ... Could you
please try to compile them? If not, I try to find time to do it.
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
