On Mon, 2015-12-07 at 15:37 +0100, Marek Vasut wrote: > On Monday, December 07, 2015 at 03:29:16 PM, Chin Liang See wrote: > > On Mon, 2015-12-07 at 15:23 +0100, Marek Vasut wrote: > > > On Monday, December 07, 2015 at 02:32:04 PM, Chin Liang See > > > wrote: > > > > On Mon, 2015-12-07 at 14:23 +0100, Marek Vasut wrote: > > > > > On Monday, December 07, 2015 at 01:53:48 PM, Chin Liang See > > > > > wrote: > > > > > > > > > > [...] > > > > > > > > > > > > diff --git a/arch/arm/mach-socfpga/board.c > > > > > > > b/arch/arm/mach > > > > > > > -socfpga/board.c > > > > > > > new file mode 100644 > > > > > > > index 0000000..a41d089 > > > > > > > --- /dev/null > > > > > > > +++ b/arch/arm/mach-socfpga/board.c > > > > > > > > > > > > I am thinking this can go into misc.c instead new file. > > > > > > > > > > misc.c is bloated with random crap already, I would like to > > > > > keep > > > > > things > > > > > orderly a little. Let's keep the board code and platform code > > > > > separated. > > > > > > > > Initial thinking misc.c should be as lean as possible but that > > > > seems > > > > not today. Can consider split them out per features such as > > > > usb.c > > > > ethernet.c. > > > > > > There is no ethernet/usb... anything in misc.c and there > > > shouldn't > > > be. > > > All of this stuff is (or should be) probed from OF :-) > > > > Looking at misc.c, yup, they are specific to socfpga such as system > > manager emac registers. Till then, good from me > > The cpu_eth_init() could use improvement, but we don't support > generic > reset handling yet I believe. That's the only thing which is > obviously > visible there, which could be improved. > > The other thing which might use improvement is the FPGA registration, > I suspect that might recycle the bindings from current linux 4.4.x at > some point and move to DT as well. >
Nice, looking forward then :) To further clean-up, I am thinking we can move do_bridge to reset_manager.c too. I can do this if it sound good to you. Thanks Chin Liang > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot