Hi Magnus, On 9/15/09, Magnus Lilja <lilja.mag...@gmail.com> wrote: > Hi > > Some minor below. > > Alan Carvalho de Assis skrev: ... >> +#include <config.h> >> +#include <asm/macro.h> >> +#include <asm/arch/imx-regs.h> >> +#include <asm/arch/asm-offsets.h> >> + >> +.macro sdram_init >> + /* >> + * DDR on CSD0 >> + */ >> + write32 0xD8001010 0x00000008 > > I would insert a comma (,) after the first argument to the macro. Didn't > know it worked without. > The same comment applies to the rest of this file. Don't know what the > U-boot coding standard says about this though. >
Hmm, I think I based on other example. Need I to replace it? >> + /* peripheral clock divider */ >> + write32 PCDR0 0x120470C3 /* FIXME */ >> + write32 PCDR1 0x03030303 /* PERDIV1=08 @133 MHz */ >> + /* PERDIV1=04 @266 MHz * >> + * / > > The last line with '* /' looks a bit odd compated to the other comments. > I will remove this extra space >> +/* >> + * Ethernet >> + */ >> +#define CONFIG_FEC_MXC >> +#define CONFIG_FEC_MXC_PHYADDR 0x1f >> +#define CONFIG_MII >> +#define CONFIG_NET_MULTI >> + >> +/*#define CONFIG_DRIVER_CS8900 1 >> +#define CS8900_BASE 0xD4020300 >> +#define CS8900_BUS16 1*/ > > Does the board have a CS8900 as well? > Yes, it has. But it is not working correctly, then I just let it commented out. Best Regards, Alan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
