Dear Alan Carvalho de Assis,
In message <37367b3a0909151307x25a0d57dt9d708ac785ff2...@mail.gmail.com> you
wrote:
>
> >> + write32 0xD8001010 0x00000008
> >
> > I would insert a comma (,) after the first argument to the macro. Didn't
> > know it worked without.
> > The same comment applies to the rest of this file. Don't know what the
> > U-boot coding standard says about this though.
>
> Hmm, I think I based on other example. Need I to replace it?
Yes, please.
> >> + /* peripheral clock divider */
> >> + write32 PCDR0 0x120470C3 /* FIXME */
> >> + write32 PCDR1 0x03030303 /* PERDIV1=08 @133 MHz */
> >> + /* PERDIV1=04 @266 MHz *
> >> + * /
> >
> > The last line with '* /' looks a bit odd compated to the other comments.
> >
>
> I will remove this extra space
In this case it will be an incorrct multi-line comment that needs to
be fixed.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Actual war is a very messy business. Very, very messy business.
-- Kirk, "A Taste of Armageddon", stardate 3193.0
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
