>From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass >Sent: Mittwoch, 28. September 2016 19:52 >Subject: Re: [PATCH] arm: imx: add i.MX53 Beckhoff CX9020 Embedded PC > >Hi, Hi Simon, thanks for the fast feedback. > >On 28 September 2016 at 09:46, <linux-kernel-...@beckhoff.com> wrote: >> From: Patrick Bruenn <p.bru...@beckhoff.com> >> >> Add CX9020 board based on mx53loco. >> Add simplified imx53 base device tree from kernel v4.8-rc8, to reuse >> serial_mxc with DTE and prepare for device tree migration of other >> functions and imx53 devices. >> >> The CX9020 differs from i.MX53 Quick Start Board by: >> - use uart2 instead of uart1 >> - DVI-D connector instead of VGA >> - no audio >> - CCAT FPGA connected to emi >> - enable rtc >> >> Signed-off-by: Patrick Bruenn <p.bru...@beckhoff.com> >> >> --- >> >> arch/arm/Kconfig | 7 + >> arch/arm/dts/Makefile | 2 + >> arch/arm/dts/imx53-cx9020.dts | 26 ++ >> arch/arm/dts/imx53.dtsi | 41 ++ >> board/beckhoff/mx53cx9020/Kconfig | 15 + >> board/beckhoff/mx53cx9020/MAINTAINERS | 6 + >> board/beckhoff/mx53cx9020/Makefile | 9 + >> board/beckhoff/mx53cx9020/imximage.cfg | 82 ++++ >> board/beckhoff/mx53cx9020/mx53cx9020.c | 564 >+++++++++++++++++++++++++++ >> board/beckhoff/mx53cx9020/mx53cx9020_video.c | 83 ++++ >> configs/mx53cx9020_defconfig | 19 + >> include/configs/mx53cx9020.h | 211 ++++++++++ >> 12 files changed, 1065 insertions(+) >> create mode 100644 arch/arm/dts/imx53-cx9020.dts >> create mode 100644 arch/arm/dts/imx53.dtsi >> create mode 100644 board/beckhoff/mx53cx9020/Kconfig >> create mode 100644 board/beckhoff/mx53cx9020/MAINTAINERS >> create mode 100644 board/beckhoff/mx53cx9020/Makefile >> create mode 100644 board/beckhoff/mx53cx9020/imximage.cfg >> create mode 100644 board/beckhoff/mx53cx9020/mx53cx9020.c >> create mode 100644 board/beckhoff/mx53cx9020/mx53cx9020_video.c >> create mode 100644 configs/mx53cx9020_defconfig >> create mode 100644 include/configs/mx53cx9020.h > >There are a few things here that should use driver model: > >- Video >- LED GPIOs >- Pinctrl > >Is that future work? > Yes. As this is my first patch, I tried to keep it as less invasive as possible. Pinctrl would be the first thing on my list, but it looked like I would have to add something similar to pinctrl-imx6/7.c for imx5 so I didn't include it into this patch. Same thing for imx53.dtsi. Right now, it is a stripped down (but diffable) version from kernel.org. My plan was to gradually migrate parts of that dtsi to u-boot, when I use them. Is that compliant with u-boot development style? Would you prefer a series with all the imx5 infrastructure patches first and the cx9020 board as last patch?
Regards, Patrick Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot