Hi York, Thank you very much. I agree with your comment.
> -----Original Message----- > From: york sun > Sent: Tuesday, November 15, 2016 5:14 AM > To: Feng Li <feng.l...@nxp.com>; u-boot@lists.denx.de > Cc: Alison Wang <alison.w...@nxp.com> > Subject: Re: [PATCH V2] Add support of ls1021a-iot > > On 11/02/2016 11:23 PM, feng.l...@nxp.com wrote: > > From: Feng Li <feng.l...@nxp.com> > > > > The patch add support ls1021a-iot. > > It supports I2C, MMC, PCIe, eTSEC, SATA, EEPROM, CPLD, HDMI, Serial > > port, HXCI, DSPI, SD boot, QSPI boot, Broadcom wifi card, QCA wifi > > card. > > You wrapped too short. You already have a README file describing what is > supported. I don't think it is necessary to put in the commit message. I will > change it to "The patch adds support for Freescale ls1021a-iot board.". If you > don't repin this patch for other reason, no action is needed from you. > > > > > Signed-off-by: Feng Li <feng.l...@nxp.com> > > Cc: York Sun <york....@nxp.com> > > Cc: Alison Wang <alison.w...@nxp.com> > > --- > > Changes for V2: > > - CPU_V7_HAS_NONSEC and CPU_V7_HAS_VIRT are moved to Kconfig > > to correctly select ARMV7_PSCI. > > - CONFIG_ARMV7_PSCI_1_0 and CONFIG_ARMV7_PSCI_GTE_1_0 are > > deleted. > > > > arch/arm/Kconfig | 15 + > > arch/arm/dts/Makefile | 3 +- > > arch/arm/dts/ls1021a-iot-duart.dts | 16 ++ > > arch/arm/dts/ls1021a-iot.dtsi | 103 +++++++ > > board/freescale/ls1021aiot/Kconfig | 15 + > > board/freescale/ls1021aiot/MAINTAINERS | 7 + > > board/freescale/ls1021aiot/Makefile | 9 + > > board/freescale/ls1021aiot/README | 58 ++++ > > board/freescale/ls1021aiot/dcu.c | 47 ++++ > > board/freescale/ls1021aiot/ls1021aiot.c | 259 +++++++++++++++++ > > board/freescale/ls1021aiot/ls102xa_pbi.cfg | 14 + > > board/freescale/ls1021aiot/ls102xa_rcw_sd.cfg | 27 ++ > > board/freescale/ls1021aiot/psci.S | 28 ++ > > configs/ls1021aiot_qspi_defconfig | 15 + > > configs/ls1021aiot_sdcard_defconfig | 17 ++ > > include/configs/ls1021aiot.h | 367 > > +++++++++++++++++++++++++ > > 16 files changed, 999 insertions(+), 1 deletion(-) create mode > > 100644 arch/arm/dts/ls1021a-iot-duart.dts > > create mode 100644 arch/arm/dts/ls1021a-iot.dtsi create mode 100644 > > board/freescale/ls1021aiot/Kconfig > > create mode 100644 board/freescale/ls1021aiot/MAINTAINERS > > create mode 100644 board/freescale/ls1021aiot/Makefile > > create mode 100644 board/freescale/ls1021aiot/README create mode > > 100644 board/freescale/ls1021aiot/dcu.c create mode 100644 > > board/freescale/ls1021aiot/ls1021aiot.c > > create mode 100644 board/freescale/ls1021aiot/ls102xa_pbi.cfg > > create mode 100644 board/freescale/ls1021aiot/ls102xa_rcw_sd.cfg > > create mode 100644 board/freescale/ls1021aiot/psci.S create mode > > 100644 configs/ls1021aiot_qspi_defconfig create mode 100644 > > configs/ls1021aiot_sdcard_defconfig > > create mode 100644 include/configs/ls1021aiot.h > > > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index > > d7a9b11..5a46ad4 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -761,6 +761,20 @@ config TARGET_LS1021ATWR > > select ARCH_SUPPORT_PSCI > > select LS1_DEEP_SLEEP > > > > +config TARGET_LS1021AIOT > > You should use a space instead of a tab here. It causes a false alarm when > compiling. I will fix this when merging. No action is needed from you. > > York Feng _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot