Hi Andy,

On 18 May 2017 at 10:01,  <s...@google.com> wrote:
> On Wed, May 3, 2017 at 5:36 AM, Simon Glass <s...@chromium.org> wrote:
>> Hi Andy,
>>
>> On 24 April 2017 at 02:04, Andy Shevchenko <andy.shevche...@gmail.com> wrote:
>>> On Mon, Apr 24, 2017 at 5:02 AM, Simon Glass <s...@chromium.org> wrote:
>>>> At present this code is inline. Move it into a function to allow it to
>>>> be used elsewhere.
>>>>
>>>> Signed-off-by: Simon Glass <s...@chromium.org>
>>>
>>>> +static int blk_next_free_devnum(enum if_type if_type)
>>>> +{
>>>> +       int ret;
>>>> +
>>>> +       ret = blk_find_max_devnum(if_type);
>>>> +       if (ret == -ENODEV)
>>>> +               return 0;
>>>
>>>> +       else if (ret < 0)
>>>
>>> Useless 'else'.
>>>
>>>> +               return ret;
>>>> +       else
>>>
>>> Ditto.

I updated these when applying.

- Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to