Gupta, Ajay Kumar wrote: > Hi, >> Hi, >>> Tested USB host functionality on DA830 EVM. >>> >>> Signed-off-by: Ajay Kumar Gupta <ajay.gu...@ti.com> >>> Signed-off-by: Swaminathan S <swami.i...@ti.com> >>> --- >> <snip..> >> >>> --- a/include/usb.h >>> +++ b/include/usb.h >>> @@ -183,7 +183,8 @@ struct usb_device { >>> #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ >>> defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ >>> defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ >>> - defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) >>> + defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ >>> + defined(CONFIG_USB_DA8XX) >>> These are aligned incorrectly (should be 4 spaces rather than a tab) >> It was originally with tabs only. Are you suggesting to change all 5 lines >> to match the alignment ? >> >> Tom, >> What do you think on this one? > >> In general tabs are preferred but I would like to review the entire patchset. >> When you make changes to a subset of the patches, you must repost the entire >> patchset. > >> Please repost the entire patchset. > > Ok sure. Shall I post this patch with tabs or with 4-spaces as Nick suggested > ? >
Just repost it as-is. Please be aware that this is a USB change. And though I can provide some input the ack/nak decision is Remy's. Tom > Regards, > Ajay > >> Tom > > >> -Ajay > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot