On Thu, 2017-07-06 at 12:07 +0800, Bin Meng wrote: > Hi Andy, > > On Thu, Jul 6, 2017 at 4:56 AM, Andy Shevchenko > <andriy.shevche...@linux.intel.com> wrote: > > Add Intel Edison board which is using U-Boot. >
Thanks for review, my answers below. > Thank you for your efforts to bring edition support upstream! Looks > quite clean. A few comments below. I hope to see it soon there! > > +config SYS_USB_OTG_BASE > > + hex > > + default 0xf9100000 > > Can this otg controller be put into device tree, like other > peripherals? I will check the possibility. > > diff --git a/board/intel/edison/edison_start.S > > b/board/intel/edison/edison_start.S > > This file should be renamed to just start.S Done. > > +U-boot is a main bootloader on Intel Edison board. > > U-Boot Fixed. > Are there instructions on how to program U-Boot on a board that does > not have pre-flashed U-Boot? or in a situation that users flashed a > bad image that makes the board brick. We assume that board is supplied with official image. There is official documentation how to "unbrick" board to the stock state. So, I consider it out of scope of U-Boot documentation. > > +/*----------------------------------------------------------------- > > ------ > > nits: /* Boot */ Fixed (all cases). -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
