On Fri, Nov 10, 2017 at 3:53 PM, Dr. Philipp Tomsich
<philipp.toms...@theobroma-systems.com> wrote:
> Kever,
>
>> On 10 Nov 2017, at 08:24, Goldschmidt Simon 
>> <sgoldschm...@de.pepperl-fuchs.com> wrote:
>>
>>>> Update rockchip U-Boot location to 0x4000/16384.
>
> At least the location given in the commit message is consistent:
>         (gdb) p 0x4000
>         $1 = 16384
>
>>>> Signed-off-by: Kever Yang <kever.y...@rock-chips.com>
>>>> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com>
>>>> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com>
>>>> ---
>>>>
>>>> doc/README.rockchip | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>
>>> Applied to u-boot-rockchip, thanks!
>>
>> I just found this commit has calculated the size wrong. 16384 blocks should 
>> be 8MB, not 4MB.
>
> Could you take a look at this and let us know if this should be changed?
> And if it needs a change (and you want it in Monday’s release): please submit 
> a
> patch and I’ll try to generate a PR to Tom over the weekend…

This even require some README.rockchip and falcon offset changes,
Sorry I really don't understand why the new features been added for
release tree.

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to