> On 10 Nov 2017, at 12:26, Jagan Teki <jagannadh.t...@gmail.com> wrote: > > On Fri, Nov 10, 2017 at 4:48 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: >> Jagan, >> >>> On 10 Nov 2017, at 12:12, Jagan Teki <ja...@amarulasolutions.com> wrote: >>> >>> On Fri, Nov 10, 2017 at 3:53 PM, Dr. Philipp Tomsich >>> <philipp.toms...@theobroma-systems.com> wrote: >>>> Kever, >>>> >>>>> On 10 Nov 2017, at 08:24, Goldschmidt Simon >>>>> <sgoldschm...@de.pepperl-fuchs.com> wrote: >>>>> >>>>>>> Update rockchip U-Boot location to 0x4000/16384. >>>> >>>> At least the location given in the commit message is consistent: >>>> (gdb) p 0x4000 >>>> $1 = 16384 >>>> >>>>>>> Signed-off-by: Kever Yang <kever.y...@rock-chips.com> >>>>>>> Acked-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >>>>>>> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >>>>>>> --- >>>>>>> >>>>>>> doc/README.rockchip | 6 +++--- >>>>>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>>>>> >>>>>> >>>>>> Applied to u-boot-rockchip, thanks! >>>>> >>>>> I just found this commit has calculated the size wrong. 16384 blocks >>>>> should be 8MB, not 4MB. >>>> >>>> Could you take a look at this and let us know if this should be changed? >>>> And if it needs a change (and you want it in Monday’s release): please >>>> submit a >>>> patch and I’ll try to generate a PR to Tom over the weekend… >>> >>> This even require some README.rockchip and falcon offset changes, >>> Sorry I really don't understand why the new features been added for >>> release tree. >> >> This is not a new feature, but merely a configuration change. >> Plus, it ensures consistency with the (legacy) vendor U-Boot. > > AFAIK, global config options sometimes new changes I've seen the > series in ML on 02/11 which is crossed MW. ie reason I've commented.
We still have a major issue with what the rk3*_common.h files affect and how the can generate unwanted side-effects. The goal should be to have these further cleaned up for the future to not have these dependencies and rather rely on each board’s DTS to configure things. >> Note that worked fine my smoke tests, as we have the offsets configured in >> the >> DTS for our boards and don’t rely on platform/chipset defaults (which will >> never >> be right for all use-cases anyway)… > > OK. > > thanks! > -- > Jagan Teki > Free Software Engineer | www.openedev.com > U-Boot, Linux | Upstream Maintainer > Hyderabad, India. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot