On 12/19/2017 05:04 PM, Chen-Yu Tsai wrote: > On Tue, Dec 12, 2017 at 11:56 PM, Marek Vasut <ma...@denx.de> wrote: >> On 12/12/2017 08:24 AM, Chen-Yu Tsai wrote: >>> Now that the musb sunxi glue driver is completely device model / device >>> tree driven, we should use the base address from the device tree, >>> instead of hard-coding it in the source code. >>> >>> Fixes: 3a61b080acee ("musb: sunxi: switch to the device model") >>> Signed-off-by: Chen-Yu Tsai <w...@csie.org> >>> --- >>> drivers/usb/musb-new/sunxi.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c >>> index 7ee44ea91900..ae6a54118cd1 100644 >>> --- a/drivers/usb/musb-new/sunxi.c >>> +++ b/drivers/usb/musb-new/sunxi.c >>> @@ -318,7 +318,7 @@ static int musb_usb_probe(struct udevice *dev) >>> >>> #ifdef CONFIG_USB_MUSB_HOST >>> host->host = musb_init_controller(&musb_plat, NULL, >>> - (void *)SUNXI_USB0_BASE); >>> + dev_read_addr_ptr(dev)); >> >> What happens if dev_read_addr_ptr() returns some non-standard value? > > You mean like an error value? That would likely be a signal that > the device tree is broken, like a missing property or invalid value, > or a corrupt device tree. In all cases I think blowing up should be > an expected result for a device tree driven driver?
What about handling the errors instead ? :) -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot