On Wed, Jan 24, 2018 at 09:26:37AM +0100, Boris Brezillon wrote: > > > > > > #define NFC_READ_CMD_OFFSET 0 > > > #define NFC_RANDOM_READ_CMD0_OFFSET 8 > > > @@ -80,22 +71,6 @@ > > > #define NFC_CMD_RNDOUT 0x05 > > > #define NFC_CMD_READSTART 0x30 > > > > > > -#define SUNXI_DMA_CFG_REG0 0x300 > > > -#define SUNXI_DMA_SRC_START_ADDR_REG0 0x304 > > > -#define SUNXI_DMA_DEST_START_ADDRR_REG0 0x308 > > > -#define SUNXI_DMA_DDMA_BC_REG0 0x30C > > > -#define SUNXI_DMA_DDMA_PARA_REG0 0x318 > > > - > > > -#define SUNXI_DMA_DDMA_CFG_REG_LOADING (1 << 31) > > > -#define SUNXI_DMA_DDMA_CFG_REG_DMA_DEST_DATA_WIDTH_32 (2 << 25) > > > -#define SUNXI_DMA_DDMA_CFG_REG_DDMA_DST_DRQ_TYPE_DRAM (1 << 16) > > > -#define SUNXI_DMA_DDMA_CFG_REG_DMA_SRC_DATA_WIDTH_32 (2 << 9) > > > -#define SUNXI_DMA_DDMA_CFG_REG_DMA_SRC_ADDR_MODE_IO (1 << 5) > > > -#define SUNXI_DMA_DDMA_CFG_REG_DDMA_SRC_DRQ_TYPE_NFC (3 << 0) > > > - > > > -#define SUNXI_DMA_DDMA_PARA_REG_SRC_WAIT_CYC (0x0F << 0) > > > -#define SUNXI_DMA_DDMA_PARA_REG_SRC_BLK_SIZE (0x7F << 8) > > > - > > > > We should probably keep those values. They're not used anymore, but > > the NAND controller has been under-documented on most of the datasheet > > we've had. It's good to keep it at least for reference. > > > > Hm, your statement is valid for the NFC_ defs, but these are purely DMA > engine related definitions, so I think we can get rid of them.
Oh, right, we can totally remove those. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot