Hi Maxime, On Wed, 24 Jan 2018 08:56:38 +0100 Maxime Ripard <maxime.rip...@free-electrons.com> wrote:
> Hi, > > On Wed, Jan 24, 2018 at 01:44:50AM +0100, Miquel Raynal wrote: > > Do some cleaning in sunxi NAND SPL driver like adding helpers and > > clearing flags at the right spot > > > > Signed-off-by: Miquel Raynal <miquel.ray...@free-electrons.com> > > I'm not really fond of these kind of wildcard patches, especially > since.. > [...] > > Overall, I think it would be great to split that patch into 4: > - the first one to fix the ADR vs ADDR typo (without changing the order) > - the second one to introduce the nand_wait_int helper > - the third one to introduce the nand_wait_cmd_fifo_empty, with a > proper commit log explaining why this needs to be done and which > issues is it fixing > - And maybe if justified moving the ecc_bytes array to global scope I split this patch into 4 logical peaces, as requested. Thanks, Miquèl _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot