On Wed, Feb 07, 2018 at 12:55:54PM +0530, Jagan Teki wrote: > >>>>> +&spi0 { > >>>>> + pinctrl-names = "default"; > >>>>> + pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>; > >>>>> + status = "okay"; > >>>>> + > >>>>> + flash: w25q128@0 { > >>>> > >>>> Was it sync from Linux? > >>> > >>> No, this isn't in the linux dts. > >> > >> But we have to, please send it to Linux first. > > > > We've already commented this issue. In the v2 [1], I've explained that this > > won't go mainline, since it's optional feature. Rather it will be managed > > with overlays. > > Thought this was already in ML, and ready to merge. So this never go > to Linux tree since it's optional? then add u-boot.dtsi for this > atleast since we always sync dts from Linux.
This is an optional feature on that board. We should be making it as easy as possible to enable it, but a defconfig is a *default* configuration, and if the board doesn't have it by default, it shouldn't be enabled in the defconfig. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot