On Thu, Feb 08, 2018 at 12:33:37PM +0530, Jagan Teki wrote: > On Thu, Feb 8, 2018 at 11:54 AM, Stefan Mavrodiev > <stefan.mavrod...@gmail.com> wrote: > > On 02/07/2018 07:19 PM, Maxime Ripard wrote: > >> > >> On Wed, Feb 07, 2018 at 12:55:54PM +0530, Jagan Teki wrote: > >>>>>>>> > >>>>>>>> +&spi0 { > >>>>>>>> + pinctrl-names = "default"; > >>>>>>>> + pinctrl-0 = <&spi0_pins_b>, <&spi0_cs0_pins_b>; > >>>>>>>> + status = "okay"; > >>>>>>>> + > >>>>>>>> + flash: w25q128@0 { > >>>>>>> > >>>>>>> Was it sync from Linux? > >>>>>> > >>>>>> No, this isn't in the linux dts. > >>>>> > >>>>> But we have to, please send it to Linux first. > >>>> > >>>> We've already commented this issue. In the v2 [1], I've explained that > >>>> this > >>>> won't go mainline, since it's optional feature. Rather it will be > >>>> managed > >>>> with overlays. > >>> > >>> Thought this was already in ML, and ready to merge. So this never go > >>> to Linux tree since it's optional? then add u-boot.dtsi for this > >>> atleast since we always sync dts from Linux. > >> > >> This is an optional feature on that board. We should be making it as > >> easy as possible to enable it, but a defconfig is a *default* > >> configuration, and if the board doesn't have it by default, it > >> shouldn't be enabled in the defconfig. >> > > Sorry, but I'm really confused. In the first patch Jagan said to > > make separate patch "just to test" the driver. Then I've made > > patch "just to test", and it's turn out it wasn't not OK, because > > it should be compatible with linux, u-boot and etc. What's the > > point since it's just for testing...? > > > > Sorry again, but can someone explain to me, that to do? I'm not > > trying to pick on you guys. Just want to do the right thing. > > I think we're in out-of-sync for some reason. > > Here is my suggestion: Since it is "optional feature however similar > boards of this type could not have it"? > > How about separate defconfig file? > A20-OLinuXino-Lime2-spinor_defconfig and have same dts file with > > /* Disable SPI NOR by default: it optional on A20-OLinuXino-Lime2 boards */ > status = "disabled"; > > But the dts should accept by Linux as well.
We won't merge it in Linux. And I still don't really get why you want it to be enabled by default in U-Boot either. That patch has been introduced by Stefan as a patch not intended to be merged but just showing how his driver was useful. Can't we just merge the SPI driver and be done with it? Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot