Dear Wolfgang: I will withdraw this patch. Feng ________________________________
From: Wolfgang Denk [mailto:w...@denx.de] Sent: Mon 2/22/2010 12:54 PM To: Feng Kan Cc: Stefan Roese; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 1/1] ppc4xx: add support for alternate format for ndfc Dear Feng Kan, In message <2b3b2aa816369a4e87d7be63ec9d2f260615a...@sdcexchange01.ad.amcc.com> you wrote: > > There is not a particular board that is stuck on this 213 format. Rather, > for sometime u-boot > and linux both had the 213 ordering. Lets say the guy did not have the SMC > define turned on, > which mean the ECC would caculate correctly for him. Now, he gets a new > U-boot and want > to update it. He gets to prompt and programs the new u-boot and linux (in 213 > ordering). > The new uboot comes up (it doesn't complain since there is no error message), > runs to linux, > the new linux expects 123 ordering. Finds ECC error and tries to correct and > crash. If this is your concern, then a compile-time setting makes little sense - you don't really expect that a user in this situation will build another U-Boot image after selecting other build options, install it (with the risk of bricking his device (keep in mind that not everybody has access to a JTAG debugger), and continue this so long until he finds a configuration that works for his combination of U-Boot and Linux settings. > I submitted this patch to support both ordering that the correction routine > contains (123 and 213). But it makes no sense as a compile time option. If you want to help users, then this must be implemented in a way that is selectable at run-time, for example by simple setting an Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Everybody is talking about the weather but nobody does anything about it." - Mark Twain
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot