On Thu, Aug 30, 2018 at 12:44:00AM -0300, Ezequiel Garcia wrote: > On 30 August 2018 at 00:00, Manivannan Sadhasivam > <manivannan.sadhasi...@linaro.org> wrote: > > Hi Ezequiel, > > > > On Wed, Aug 29, 2018 at 03:11:17AM -0300, Ezequiel Garcia wrote: > >> Hi Manivannan, > >> > >> On 21 August 2018 at 14:09, Manivannan Sadhasivam > >> <manivannan.sadhasi...@linaro.org> wrote: > >> > This patchset adds board support for Vamrs Limited Rock960, > >> > which is one of the 96Boards Consumer Edition platform based > >> > on Rockchip RK3399 SoC. > >> > > >> > >> What are the differences between this consumer edition board, > >> and the enterprise edition (aka Ficus) Vamrs board? > >> > > > > I asked Vamrs about this and they said the difference is very minimal. > > > > In that case, you should try to leverage the Linux ficus.dts: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/rockchip/rk3399-ficus.dts > > If no differences, using the ficus dts should do. If there are differences, > we can create a common rock960.dtsi and then enterprise and consumer > edition dts. >
Okay. Here are the differences between Ficus and Rock960 CE: 1. Different host enable GPIO for USB (vcc5v0_host) 2. Different power and reset for PCI-E (vcc3v3_pcie, pcie0) 3. No Ethernet port on Rock960 (gmac) So, I would suggest keeping USB, PCI-E and GMAC related nodes on the board specific devicetree and rest on the rk3399-rock960.dtsi. What do you think? Same applies to Linux also! Thanks, Mani > >> Perhaps the devicetree and the board support can be > >> shared with ficus support? > >> > > > > I'm fine with it but you seem to have added Ficus board under > > evb_rk3399 which I think not the good place. Since the board > > manufacturer is different, I would suggest you to place it under > > boards/vamrs as I have done here. Also with more boards coming from > > Vamrs, this makes much more sense. > > > > Please let me know your thoughts! > > > > Well, I've reused the evb support, because there was no reason > to have board-specific code. If we have now a reason, then of course > having a board dir makes sense. > > When possible, we should try to avoid code duplication and scattering. > For instance, the instructions in the README look RK3399 generic > and not board specific. We should consolidate that. > -- > Ezequiel GarcĂa, VanguardiaSur > www.vanguardiasur.com.ar _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot