On Sun, 14 Apr 2019, Marek Vasut wrote:
> On 4/14/19 12:06 PM, Robert P. J. Day wrote:
> >
> > Kbuild "select" directives should not include "CONFIG_" prefix.
> >
> > Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca>
>
> The patch is correct, but does it have any side-effects ?
>
> > ---
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index ba1e6bfa43..96474f4e3b 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
> > config USB_EHCI_FSL
> > bool "Support for FSL on-chip EHCI USB controller"
> > default n
> > - select CONFIG_EHCI_HCD_INIT_AFTER_RESET
> > + select EHCI_HCD_INIT_AFTER_RESET
> > ---help---
> > Enables support for the on-chip EHCI controller on FSL chips.
> > endif # USB_EHCI_HCD
> >
there are a *ton* of include/configs/ header files that
already contain:
#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
and the only test i can see for it is in drivers/usb/host/ehci-hcd.c:
#if defined(CONFIG_EHCI_HCD_INIT_AFTER_RESET)
rc = ehci_hcd_init(index, init, &ctrl->hccr, &ctrl->hcor);
if (rc)
return rc;
#endif
so i would *think* that, given the number of boards that already
explicitly include that feature, it's unlikely that fixing that
Kconfig file would suddenly reveal an issue that was hidden until now.
but that's just a guess.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
