On 4/14/19 1:40 PM, Robert P. J. Day wrote: > On Sun, 14 Apr 2019, Marek Vasut wrote: > >> On 4/14/19 12:51 PM, Robert P. J. Day wrote: >>> On Sun, 14 Apr 2019, Marek Vasut wrote: >>> >>>> On 4/14/19 12:06 PM, Robert P. J. Day wrote: >>>>> >>>>> Kbuild "select" directives should not include "CONFIG_" prefix. >>>>> >>>>> Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca> >>>> >>>> The patch is correct, but does it have any side-effects ? >>>> >>>>> --- >>>>> >>>>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >>>>> index ba1e6bfa43..96474f4e3b 100644 >>>>> --- a/drivers/usb/host/Kconfig >>>>> +++ b/drivers/usb/host/Kconfig >>>>> @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC >>>>> config USB_EHCI_FSL >>>>> bool "Support for FSL on-chip EHCI USB controller" >>>>> default n >>>>> - select CONFIG_EHCI_HCD_INIT_AFTER_RESET >>>>> + select EHCI_HCD_INIT_AFTER_RESET >>>>> ---help--- >>>>> Enables support for the on-chip EHCI controller on FSL chips. >>>>> endif # USB_EHCI_HCD >>>>> >>> >>> there are a *ton* of include/configs/ header files that >>> already contain: >>> >>> #define CONFIG_EHCI_HCD_INIT_AFTER_RESET >> >> And those boards also enable USB_EHCI_FSL ? If so, then it might >> also make sense to remove these #define >> CONFIG_EHCI_HCD_INIT_AFTER_RESET from the header files. >> >> I think ./tools/moveconfig.py could help you with that cleanup . > > ok, i'll take a closer look first chance i get. clearly, there's > potentially more cleanup here than just fixing a typo.
Thanks! -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot