Hello Reinhard, On Sun, Jun 6, 2010 at 4:52 AM, Reinhard Meyer (-VC) < reinhard.me...@emk-elektronik.de> wrote:
> Wolfgang Denk schrieb: > > Dear "Reinhard Meyer (-VC)", > > > > In message <4c0b85d8.4070...@emk-elektronik.de> you wrote: > >> is this patch going to be accepted, or is someone insisting that only > >> my port shall return the number of controllers initialized? > > > > I don't understand what you mean by "only my port". Ben's comment that > > board_eth_init() is supposed to retrurn the number of successfully > > initialized controllers has been standard policy for a pretty long > > time, and many boards do so. > > > > Eventually the boards you compared against are older ones, and have > > not been maintained well, so they misbehave in this regard? > > > > Best regards, > > > > Wolfgang Denk > > > > Hello Wolfgang, > > Is that documented somewhere? I see that the calling function in net.c > does NOT care about any positive interger result. Will it care sometime > in the future? :) > > Yes, it's documented (doc/README.drivers.eth). Maybe it will get used in the future. That's why I politely asked to to make a simple change. It wasn't an arbitrary request, and most boards (maybe not most MACB-using ones) do it properly. regards, Ben
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot