On Jun 10, 2010, at 8:58 PM, Timur Tabi wrote:

> On Wed, Jun 9, 2010 at 11:18 PM, Kumar Gala <ga...@kernel.crashing.org> wrote:
>>  static int do_errata(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>>  {
>> +       __maybe_unused u32 svr = get_svr();
>> +
>> +#if defined(CONFIG_FSL_SATA_V2) && defined(CONFIG_FSL_SATA_ERRATUM_A001)
>> +       if (IS_SVR_REV(svr, 1, 0) &&
>> +           ((SVR_SOC_VER(svr) == SVR_P1022) ||
>> +            (SVR_SOC_VER(svr) == SVR_P1022_E) ||
>> +            (SVR_SOC_VER(svr) == SVR_P1013) ||
>> +            (SVR_SOC_VER(svr) == SVR_P1013_E))) {
>> +               puts("Work-around for Erratum SATA A001 enabled\n");
>> +       }
>> +#endif
>> +
>>        return 0;
>>  }
> 
> How are you planning on handling chip-specific errata?  Do you forsee
> do_errata() containing code for every erratum of every chip?

Yes, we can split it up into functions as it grows.

- k
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to