On Jul 14, 2010, at 4:43 PM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <1279142410-30629-1-git-send-email-ga...@kernel.crashing.org> you 
> wrote:
>> Add 'errata' command to report what errata we workaround.  Report
>> workaround for erratum SATA-A001 on P1022/P1013.
>> 
>> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org>
> ...
>> +#if defined(CONFIG_FSL_SATA_V2) && defined(CONFIG_FSL_SATA_ERRATUM_A001)
>> +    if (IS_SVR_REV(svr, 1, 0)) {
>> +            switch (SVR_SOC_VER(svr)) {
>> +            case SVR_P1013:
>> +            case SVR_P1013_E:
>> +            case SVR_P1022:
>> +            case SVR_P1022_E:
>> +                    puts("Work-around for Erratum SATA A001 enabled\n");
>> +            }
> 
> I think there should be a "default" case?

No, since if you dont match you dont have the errata.

> 
>> +++ b/include/configs/P1022DS.h
>> @@ -345,6 +345,7 @@
>> #define CONFIG_CMD_ELF
>> #define CONFIG_CMD_IRQ
>> #define CONFIG_CMD_SETEXPR
>> +#define CONFIG_CMD_ERRATA

will do

- k
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to