On Wed, Nov 27, 2019 at 11:56:15AM +0100, Lukasz Majewski wrote:
> Thank you for your work on enhancing DFU. The patch series is generally
> Ok.
>
> Please find some minor comments/requests below.
Thank you for review, my answers below.
> > +#ifdef CONFIG_DFU_TIMEOUT
> > + dfu_set_timeout(value * 1000);
> > +#endif
(1)
> > +#ifdef CONFIG_DFU_TIMEOUT
> > +void dfu_set_timeout(unsigned long timeout)
> > +{
> > + dfu_timeout = timeout;
> > +}
>
> I do guess that dfu_set_timeout() is not yet used in this patch series?
I think you missed (1) by some reason.
> Please add some description and example of this new option / feature to
> ./doc/README.dfu file.
Will do for v2.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
