Hi Andy, > On Wed, Nov 27, 2019 at 11:56:15AM +0100, Lukasz Majewski wrote: > > > Thank you for your work on enhancing DFU. The patch series is > > generally Ok. > > > > Please find some minor comments/requests below. > > Thank you for review, my answers below. > > > > +#ifdef CONFIG_DFU_TIMEOUT > > > + dfu_set_timeout(value * 1000); > > > +#endif > > (1) > > > > +#ifdef CONFIG_DFU_TIMEOUT > > > +void dfu_set_timeout(unsigned long timeout) > > > +{ > > > + dfu_timeout = timeout; > > > +} > > > > I do guess that dfu_set_timeout() is not yet used in this patch > > series? > > I think you missed (1) by some reason.
Right. Thanks for pointing this out. > > > Please add some description and example of this new option / > > feature to ./doc/README.dfu file. > > Will do for v2. > Thanks, appreciated. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpdoOkIWdjhV.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot