Hello Claudius,
On Thu, 2019-11-28 at 13:06 +0100, Claudius Heine wrote:
> Hi,
>
> currently the reset on the DHCOM i.MX6 board is brocken in u-boot.
>
> This patchset fixes that by integrating the sysreset and watchdog dm driver.
I think you should clarify that reset was broken by commit f2929d11a639
("watchdog: imx: Use immediate reset bits for expire_now") which changed
reset to, by default, only assert the external reset [1]. DHCOM i.MX6
needs the internal reset though, which previously was asserted as as
well. Maybe you can add a `Fixes:` line to one of your commits?
Additionally, I am still unsure whether the current default behavior is
correct. I'd rather assert both external and internal reset, which is
what the i.MX watchdog does on timeout as well (as long as WDT bit is
set, which we do by default [2]). There is also an inconsistency
between the non-DM implementation (external by default) and DM
implementation (internal by default).
> regards,
> Claudius
>
> Claudius Heine (4):
> ARM: dts: dh-imx6: add wdt-reboot node for sysreset driver
> ARM: imx6: DHCOM i.MX6 PDK: Enable sysreset driver
> ARM: imx6: DHCOM i.MX6 PDK: Enable wdt command
> ARM: imx6: DHCOM i.MX6 PDK: Use HW_WATCHDOG in SPL
>
> arch/arm/dts/imx6qdl-dhcom-pdk2.dtsi | 5 +++++
> configs/dh_imx6_defconfig | 3 +++
> include/configs/dh_imx6.h | 5 +++++
> 3 files changed, 13 insertions(+)
>
[1]:
https://gitlab.denx.de/u-boot/u-boot/blob/master/drivers/watchdog/imx_watchdog.c#L45
[2]:
https://gitlab.denx.de/u-boot/u-boot/blob/master/drivers/watchdog/imx_watchdog.c#L96
--
Harald
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
