Hi Harald,
On 28/11/2019 13.34, Harald Seiler wrote:
> Hello Claudius,
>
> On Thu, 2019-11-28 at 13:06 +0100, Claudius Heine wrote:
>> Hi,
>>
>> currently the reset on the DHCOM i.MX6 board is brocken in u-boot.
>>
>> This patchset fixes that by integrating the sysreset and watchdog dm driver.
>
> I think you should clarify that reset was broken by commit f2929d11a639
> ("watchdog: imx: Use immediate reset bits for expire_now") which changed
> reset to, by default, only assert the external reset [1]. DHCOM i.MX6
> needs the internal reset though, which previously was asserted as as
> well. Maybe you can add a `Fixes:` line to one of your commits?
Hmm... Not sure which of the commit should have the 'Fixes' line though,
since each does some part of fixing it. Maybe I should squash them?
>
> Additionally, I am still unsure whether the current default behavior is
> correct. I'd rather assert both external and internal reset, which is
> what the i.MX watchdog does on timeout as well (as long as WDT bit is
> set, which we do by default [2]). There is also an inconsistency
> between the non-DM implementation (external by default) and DM
> implementation (internal by default).
Yes, but that is a separate discussion IMO. This patch just addresses
the stuff for DHCOM does not touch the imx-watchdog driver. Maybe an RFC
patch that fixes the inconsistency might be useful to start it.
regards,
Claudius
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
