On Thu, Aug 13, 2020 at 07:47:52AM +0200, Stefan Roese wrote:
> Since commit 86cf1c82850f ("configs: Migrate CONFIG_NR_DRAM_BANKS") &
> commit 999a772d9f24 ("Kconfig: Migrate CONFIG_NR_DRAM_BANKS"),
> CONFIG_NR_DRAM_BANKS is always defined with a value (4 is default).
> It makes no sense to still carry code that is guarded with
> "#ifndef CONFIG_NR_DRAM_BANKS" (and similar). This patch removes
> all these unreferenced code paths.

...

>       int pci_addr_cells, addr_cells, size_cells;
> +     struct bd_info *bd = gd->bd;
>       int cells_per_record;
>       const u32 *prop;
>       int len;

>       /* Add a region for our local memory */

> -#ifdef CONFIG_NR_DRAM_BANKS
> -     struct bd_info *bd = gd->bd;
> -

Can we leave assignment here?

>       if (!bd)
>               return;

-- 
With Best Regards,
Andy Shevchenko


Reply via email to