Dear York Sun,
In message <[email protected]> you wrote:
> A worker function __setup_ddr_tlbs() is introduced to implement more
> control on physical address mapping.
The __ name prefix has a special, reserved meaning. What is your
rationale for using it here?
> +unsigned int setup_ddr_tlbs(unsigned int memsize_in_meg)
> +{
> + return
> + __setup_ddr_tlbs(CONFIG_SYS_DDR_SDRAM_BASE, memsize_in_meg);
Remove line break.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
