Tom, On Wed, Oct 28, 2020 at 11:22:29PM -0400, Tom Rini wrote: > On Thu, Oct 29, 2020 at 09:59:12AM +0900, AKASHI Takahiro wrote: > > Tom, > > > > On Wed, Oct 28, 2020 at 08:30:49PM -0400, Tom Rini wrote: > > > On Thu, Oct 29, 2020 at 09:25:11AM +0900, AKASHI Takahiro wrote: > > > > > > > # > > > > # This is a reminder. Nothing changed, but rebasing. > > > > # > > > > > > Wasn't one of the outstanding requests to make the DFU related changes > > > less intrusive and thus easier to review > > > > I don't know what you're talking about. > > I believe that I have addressed all the comments made on DFU stuff. > > Please go back and re-read the v5 thread then. What you're doing today > causes odroid, trats, trats2 and s5p_goni to fail to build now and I > believe there was a suggestion what to do to fix that, previously. > > > > > There used to be a prerequisite patch from Heinrich, but he decided > > to drop it. Necessary modification was done in v5. > > > > > by someone (me) who is not the > > > primary author of the DFU code but does want to unblock this overall > > > series right here? > > > > So you can review DFU part now (or even against the original v6). > > # Another minor issue: the name of file, dfu_alt.c > > # It will never be a blocking factor of your review, though. > > > > The only outstanding issue is on make-virt-fs[1]. > > Here, my standpoint is clear: Heinrich's patch. > > It is the only solution as far as Heinrich does reject any other solution > > using 'sudo' in python scripts. > > Which is I guess why the tests fail to run here: > https://gitlab.denx.de/u-boot/u-boot/-/jobs/171480 > and why I think I had suggested that you need to do some try/catch logic > so that if one set of tools isn't available, the other set of tools will > be used.
I think you misunderstand my point. Whatever logic I add, Heinrich will reject that solution if it includes "sudo". As far as I can imagine, "sudo" is necessary to workaround the issue because we need some way to create a filesystem with partitions. Whether a tool, make-virt-fs in this case, is available or not doesn't matter. -Takahiro Akashi > -- > Tom