On Thu, Oct 29, 2020 at 01:40:31PM +0900, AKASHI Takahiro wrote: > On Wed, Oct 28, 2020 at 11:22:29PM -0400, Tom Rini wrote: > > On Thu, Oct 29, 2020 at 09:59:12AM +0900, AKASHI Takahiro wrote: > > > Tom, > > > > > > On Wed, Oct 28, 2020 at 08:30:49PM -0400, Tom Rini wrote: > > > > On Thu, Oct 29, 2020 at 09:25:11AM +0900, AKASHI Takahiro wrote: > > > > > > > > > # > > > > > # This is a reminder. Nothing changed, but rebasing. > > > > > # > > > > > > > > Wasn't one of the outstanding requests to make the DFU related changes > > > > less intrusive and thus easier to review > > > > > > I don't know what you're talking about. > > > I believe that I have addressed all the comments made on DFU stuff. > > > > Please go back and re-read the v5 thread then. What you're doing today > > causes odroid, trats, trats2 and s5p_goni to fail to build now and I > > believe there was a suggestion what to do to fix that, previously. > > Okay, I have missed it. > Is this the reason that I have seen your review comments in more than > one month?
To be clear, I reported a fail to build at the time and yes, I was waiting for that to be addressed before reviewing everything else. -- Tom
signature.asc
Description: PGP signature
