Update Tom's address On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote: > > It seems nobody tested the debug() option in spin_lock_irqsave(). > Currently, when #define DEBUG, it spoils the compiler with > > In file included from drivers/usb/dwc3/gadget.c:18: > drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_set_selfpowered’: > include/log.h:235:4: warning: ‘flags’ is used uninitialized in this function > [-Wuninitialized] > 235 | printf(pr_fmt(fmt), ##args); \ > | ^~~~~~ > drivers/usb/dwc3/gadget.c:1347:17: note: ‘flags’ was declared here > 1347 | unsigned long flags; > | ^~~~~ > > and so on... > Drop useless debug() call to make compiler happy. > > Fixes: 0c06db598367 ("lib, linux: move linux specific defines to > linux/compat.h") > Cc: Heiko Schocher <h...@denx.de> > Cc: Tom Rini <tr...@ti.com> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > include/linux/compat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/compat.h b/include/linux/compat.h > index 38549baa251d..3d0acbd582ef 100644 > --- a/include/linux/compat.h > +++ b/include/linux/compat.h > @@ -248,7 +248,7 @@ typedef int wait_queue_head_t; > #define spin_lock_init(lock) do {} while (0) > #define spin_lock(lock) do {} while (0) > #define spin_unlock(lock) do {} while (0) > -#define spin_lock_irqsave(lock, flags) do { debug("%lu\n", flags); } while > (0) > +#define spin_lock_irqsave(lock, flags) do {} while (0) > #define spin_unlock_irqrestore(lock, flags) do { flags = 0; } while (0) > > #define DEFINE_MUTEX(...) > -- > 2.29.2 >
-- With Best Regards, Andy Shevchenko